Changeset 1684 in tailor

Timestamp:

03/13/11 16:06:26 (14 months ago)

Author:

lele@…

Hash name:

20110313150626-7a6fb-910e0e5f49b347fd06614885ad1a62e25e883d3c

Message:

Better check against empty log messages in darcs target

File:

• vcpx/repository/darcs/target.py (modified) (2 diffs)

vcpx/repository/darcs/target.py

@@ -111 +111 @@
 
         logmessage.append(date.astimezone(UTC).strftime('%Y/%m/%d %H:%M:%S UTC'))
-        logmessage.append(author)
+        # Paranoid protection against newlines in author
+        logmessage.append(''.join(author.split('\n')))
+        # Patchname cannot start with a newline
+        patchname = patchname.lstrip('\n')
         if patchname:
             logmessage.append(patchname)
@@ -122 +125 @@
                 while changelog.startswith('\n'):
                     changelog = changelog[1:]
+            if not changelog:
+                # No patch name and no changelog: force non empty one
+                logmessage.append(' ')
         if changelog:
             logmessage.append(changelog)
-        else:
-            logmessage.append('Unnamed patch')
 
         cmd = self.repository.command("record", "--all", "--pipe", "--ignore-times")