Changeset 1536 in tailor

Timestamp:

05/23/08 22:18:56 (4 years ago)

Author:

lele@…

Hash name:

20080523201856-97f81-c04d8df6320a24983c6df55ff2fd41b5e3bf04fa

Message:

Write directly into the pending file instead of using darcs commands
This is may be a dirty trick, or simply a clever idea: it allows the
backend to ignore the fact that the source already has
moved/deleted/renamed stuff around. It now just takes note of what
happend, and thus is able to handle difficult cases such as

$ bzr mv A B
$ touch A
$ bzr add A

File:

• vcpx/repository/darcs/target.py (modified) (2 diffs)

vcpx/repository/darcs/target.py

@@ -29 +29 @@
     A target working directory under ``darcs``.
     """
-
-    def _addPathnames(self, names):
-        """
-        Add some new filesystem objects.
-        """
-
-        cmd = self.repository.command("add", "--case-ok", "--not-recursive",
-                                      "--quiet")
-        add = ExternalCommand(cwd=self.repository.basedir, command=cmd)
-        output = add.execute(names, stdout=PIPE, stderr=STDOUT)[0]
-        if add.exit_status:
-            self.log.warning("%s returned status %d, saying %s",
-                             str(add), add.exit_status, output.read())
 
     def _addSubtree(self, subdir):
@@ -105 +92 @@
                     "Changes left in working dir after commit:\n%s" % output.read())
 
-    def _removePathnames(self, names):
-        """
-        Remove some filesystem object.
-        """
-
-        from os.path import join, exists
-
-        # darcs raises status 512 when it does not find the entry,
-        # removed by source. Since sometime a directory is left there
-        # because it's not empty, darcs fails. So, do an explicit
-        # remove on items that are still there.
-
-        c = ExternalCommand(cwd=self.repository.basedir,
-                            command=self.repository.command("remove"))
-        existing = [n for n in names if exists(join(self.repository.basedir, n))]
-        if existing:
-            output = c.execute(existing, stdout=PIPE, stderr=STDOUT)[0]
-            if c.exit_status:
-                self.log.warning("%s returned status %d, saying %s",
-                                 str(c), c.exit_status, output.read())
-
-    def _renamePathname(self, oldname, newname):
-        """
-        Rename a filesystem object.
-        """
-
-        cmd = self.repository.command("mv")
-        mv = ExternalCommand(cwd=self.repository.basedir, command=cmd)
-        output = mv.execute(oldname, newname, stdout=PIPE, stderr=STDOUT)[0]
-        if mv.exit_status:
-            self.log.warning("%s returned status %d, saying %s",
-                             str(mv), mv.exit_status, output.read())
+    def _replayChangesetEntries(self, changeset):
+        """
+        Instead of using the "darcs mv" command, manually add
+        the rename to the pending file: this is a dirty trick, that
+        allows darcs to handle the case when the source changeset
+        is something like::
+          $ bzr mv A B
+          $ touch A
+          $ bzr add A
+        where A is actually replaced, and old A is now B. Since by the
+        time the changeset gets replayed, the source has already replaced
+        A with its new content, darcs would move the *wrong* A to B...
+        """
+
+        from os.path import join
+
+        # The "_darcs/patches/pending" file is basically a patch containing
+        # only the changes (hunks, adds...) not yet recorded by darcs: it does
+        # contain either a single change (that is, exactly one line), or a
+        # collection of changes, with opening and closing curl braces.
+        # Filenames must begin with "./", and eventual spaces replaced by '\32\'.
+        # Order is significant!
+
+        pending = join(self.repository.basedir, '_darcs', 'patches', 'pending')
+        p = open(pending).readlines()
+        if p[0] != '{\n':
+            p.insert(0, '{\n')
+            p.append('}\n')
+
+        changed = False
+        adapted = self._adaptChangeset(changeset)
+        for e in adapted.entries:
+            if e.action_kind == e.RENAMED:
+                self.log.debug('Mimicing "darcs mv %s %s"',
+                               e.old_name, e.name)
+                oname = e.old_name.replace(' ', '\\32\\')
+                nname = e.name.replace(' ', '\\32\\')
+                p.insert(-1, 'move ./%s ./%s\n' % (oname, nname))
+                changed = True
+            elif e.action_kind == e.ADDED:
+                self.log.debug('Mimicing "darcs add %s"', e.name)
+                name = e.name.replace(' ', '\\32\\')
+                if e.is_directory:
+                    p.insert(-1, 'adddir ./%s\n' % name)
+                else:
+                    p.insert(-1, 'addfile ./%s\n' % name)
+                changed = True
+            elif e.action_kind == e.DELETED:
+                self.log.debug('Mimicing "darcs rm %s"', e.name)
+                name = e.name.replace(' ', '\\32\\')
+                if e.is_directory:
+                    p.insert(-1, 'rmdir ./%s\n' % name)
+                else:
+                    p.insert(-1, 'rmfile ./%s\n' % name)
+                changed = True
+        if changed:
+            open(pending, 'w').writelines(p)
+        return True
 
     def _prepareTargetRepository(self):