Changeset 411 in tailor

Timestamp:

07/07/05 03:24:43 (8 years ago)

Author:

lele@…

Hash name:

20050707012443-97f81-ce365f345b0afdab91f4ce17d57459be20666c68

Message:

Move the translation of illegal chars into the function that applies it

File:

• vcpx/svn.py (modified) (2 diffs)

vcpx/svn.py

@@ -19 +19 @@
 SVN_CMD = "svn"
 
-import string
-allbadchars="\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0B\x0C\x0E\x0F\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F\x7f"
-TT = string.maketrans(allbadchars, "?"*len(allbadchars))
-
 def changesets_from_svnlog(log, url, repository, module):
-    from xml.sax import parse
+    from xml.sax import parseString
     from xml.sax.handler import ContentHandler
     from changes import ChangesetEntry, Changeset
     from datetime import datetime
+    from string import maketrans
 
     def get_entry_from_path(path, module=module):
@@ -162 +159 @@
 
 
+    # Apparently some (SVN repo contains)/(SVN server dumps) some characters that
+    # are illegal in an XML stream. This was the case with Twisted Matrix master
+    # repository. To be safe, we replace all of them with a question mark.
+    
+    allbadchars = "\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0B\x0C\x0E\x0F\x10\x11" \
+                  "\x12\x13\x14\x15\x16\x17\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F\x7f"
+    tt = maketrans(allbadchars, "?"*len(allbadchars))
     handler = SvnXMLLogHandler()
-    parseString(log.read(), handler)
+    parseString(log.read().translate(tt), handler)
     return handler.changesets