Changeset 585 in tailor

Timestamp:

08/16/05 00:42:40 (8 years ago)

Author:

lele@…

Hash name:

20050815224240-97f81-316f2e9aa2fe6f1c5af73609f25420d37d7a3ac8

Message:

Raise an OSError when an external command is not found

Location:

vcpx

Files:

• shwrap.py (modified) (1 diff)
• tests/shwrap.py (modified) (1 diff)

vcpx/shwrap.py

@@ -160 +160 @@
                             cwd=kwargs.get('cwd'),
                             universal_newlines=True)
-        except OSError:
-            stderr.write("'%s' does not exist!" % self._last_command[0])
-            self.exit_status = -1
-            return
+        except OSError, e:
+            from errno import ENOENT
+
+            if e.errno == ENOENT:
+                raise OSError("'%s' does not exist!" % self._last_command[0])
+            else:
+                raise
 
         if input:

vcpx/tests/shwrap.py

@@ -30 +30 @@
 
     def testExitStatusUnknownCommand(self):
-        """Verify ExternalCommand exit_status for non existing command.
+        """Verify ExternalCommand raise OSError for non existing command.
         """
 
         c = ExternalCommand(['/does/not/exist'])
-        c.execute()
-        self.assertNotEqual(c.exit_status, 0)
+        self.assertRaises(OSError, c.execute)
 
     def testStandardOutput(self):