Changeset 933 in tailor for vcpx/svn.py

Timestamp:

10/20/05 23:33:41 (8 years ago)

Author:

lele@…

Hash name:

20051020213341-7a6fb-a00122f770aab206ad9d16f7fd93e7c7870bc565

Message:

Use an incremental parser for svn log
This transforms the changesets_from_svnlog() function into a generator
that yields changesets as they are parsed out from XML, that is read
in chunks.

File:

• vcpx/svn.py (modified) (2 diffs)

vcpx/svn.py

@@ -18 +18 @@
 from config import ConfigurationError
 
-def changesets_from_svnlog(log, repository, module):
-    from xml.sax import parse
-    from xml.sax.handler import ContentHandler
+def changesets_from_svnlog(log, repository, module, chunksize=2**15):
+    from xml.sax import make_parser
+    from xml.sax.handler import ContentHandler, ErrorHandler
     from changes import ChangesetEntry, Changeset
     from datetime import datetime
@@ -183 +183 @@
             self.current_field.append(data)
 
+    parser = make_parser()
     handler = SvnXMLLogHandler()
-    parse(log, handler)
-    return handler.changesets
+    parser.setContentHandler(handler)
+    parser.setErrorHandler(ErrorHandler())
+
+    chunk = log.read(chunksize)
+    while chunk:
+        parser.feed(chunk)
+        for cs in handler.changesets:
+            yield cs
+        handler.changesets = []
+        chunk = log.read(chunksize)
+    parser.close()
+    for cs in handler.changesets:
+        yield cs