Ticket #11 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

Missing "-l" flag to "darcs record"

Reported by: z0200@… Owned by: lele
Priority: major Milestone: VersionOne
Component: tailor Version: 0.9
Keywords: Cc:

Description

darcs.py, line 418, should include a "-l" flag. I don't understand exactly darcs' semantics, but I used tailor to import a 400+ revision SVN tree. Without the "-l" flag it would barf after some 20 revisions. With it, tailor worked just fine (as far as I can see, so far).

Zorzella

Change History

comment:1 Changed 8 years ago by Lele Gaifax

Even if -l would fix your situation, I'd prefer understand why that happened. This is because I wanna keep changesets recognized by tailor as close as possible to what's actually happened, instead of resorting to target system ability to discover that (imagine going toward a brain damaged system like CVS that has not an equivalent of --look-for-adds).

From my experience, one situation where tailor looses files coming from svn is when the specified URL is not the root of the repository. For that reason, I just wrote a check against that that prevents it.

So please, provide some more context if you can, so that the real problem may be spotted and properly fixed.

comment:2 Changed 8 years ago by anonymous

It's, apparently, a tricky problem: if I start my import at revision 2 (see ticket #10), it barfs at revision 17. But if I start, say, at revision 16, the error does not occur (there). So it's not "local" to one change, but rather depends on a certain history.

I can't quite provide you read access to my subversion tree, but if there is anything else I can do for you, I'd be glad to do it.

I pasted at the bottom the output of "tailor -D -v", in the vicinity of the error, for what it's worth.

BTW, tailor should catch errors in the execution of the commands, and halt. It took me some time to figure out why the thing did not have all my data (that's after waiting for all 400+ revisions to be svn co'ed). It was even more strange within the context of ticket #10, where no sources had been imported to darcs.

PS: Is there any way to have these trac ticket emails have a URL to here?

*

A trunk/res/client/all/log4j.properties A trunk/res/client/all/cactus.properties A trunk/res/client/weblogic A trunk/res/client/weblogic/jndi.properties A trunk/.cvsignore A trunk/build.xml A trunk/.settings A trunk/.settings/org.eclipse.jdt.core.prefs D db.properties D config D doc D lib D src D res D .cvsignore D build.xml D .settings Updated to revision 16. /home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? Who is the author? What is the patch name? What is the log? Finished recording patch 'Tailorized "16"'

[Ok]

/home/zorzella/src/tailor-error $ svn update --revision 17 . [Ok] Output stream: A trunk/project.properties D my.properties D project.properties D bin Updated to revision 17. /home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? Who is the author? What is the patch name? What is the log? Finished recording patch 'Tailorized "17"'

[Ok]

/home/zorzella/src/tailor-error $ svn update --revision 18 . [Ok] Output stream: U trunk/config/ejb/jboss.xml D trunk/src/common/us/plarib/version.properties U trunk/res/foreclipse/.classpath Updated to revision 18. /home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? No changes!

[Ok]

/home/zorzella/src/tailor-error $ svn update --revision 19 . [Ok] Output stream: A trunk/TODO.txt

comment:3 Changed 8 years ago by anonymous

I should have escaped my last post. Here it is:

A    trunk/res/client/weblogic/jndi.properties
A    trunk/.cvsignore
A    trunk/build.xml
A    trunk/.settings
A    trunk/.settings/org.eclipse.jdt.core.prefs
D    db.properties
D    config
D    doc
D    lib
D    src
D    res
D    .cvsignore
D    build.xml
D    .settings
Updated to revision 16.
/home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? Who is the author? What is the patch name? What is the log?
Finished recording patch 'Tailorized "16"'
 [Ok]
/home/zorzella/src/tailor-error $ svn update --revision 17 . [Ok]
Output stream:
A    trunk/project.properties
D    my.properties
D    project.properties
D    bin
Updated to revision 17.
/home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? Who is the author? What is the patch name? What is the log?
Finished recording patch 'Tailorized "17"'
 [Ok]
/home/zorzella/src/tailor-error $ svn update --revision 18 . [Ok]
Output stream:
U    trunk/config/ejb/jboss.xml
D    trunk/src/common/us/plarib/version.properties
U    trunk/res/foreclipse/.classpath
Updated to revision 18.
/home/zorzella/src/tailor-error $ darcs record --all --pipeWhat is the date? No changes!
 [Ok]
/home/zorzella/src/tailor-error $ svn update --revision 19 . [Ok]
Output stream:
A    trunk/TODO.txt
U    trunk/src/css/plaribus.css
A    trunk/src/war/us/plarib/enumer/CommunityKindEnumer.java
A    trunk/src/war/us/plarib/enumer/PictureKindEnumer.java
U    trunk/src/jsp/close.jsp
U    trunk/src/jsp/memberpage.jsp
U    trunk/src/sql/populate-tables-bogus.sql
U    trunk/src/ejb/us/plarib/entity/PictureBean.java

comment:4 Changed 8 years ago by Lele Gaifax

  • Priority changed from critical to major

How about a new option auto-discover, that adds that flag? This would benefit also other backends, even if I'd still prefer fixing the source of the problem.

comment:5 Changed 7 years ago by lele

  • Status changed from new to closed
  • Resolution set to fixed

Implemented in [1056].

Note: See TracTickets for help on using tickets.