Ticket #152 (closed defect: worksforme)

Opened 4 years ago

Last modified 4 years ago

failure tailorizing libcurl's CVS history

Reported by: zooko Owned by: lele
Priority: major Milestone: VersionOne
Component: tailor Version: 0.9
Keywords: Cc:

Description

Possibly this is a darcs-2 issue?

Here is the tailor.config file: 

[DEFAULT]
remove-first-log-line = True
verbose = True
patch-name-format = %(firstlogline)s

[project]
target = darcs:target
start-revision = INITIAL
state-file = tailor.state
source = cvs:source
subdir = .

[darcs:target]
init-options = --darcs-2

[cvs:source]
module = curl
repository = :pserver:anonymous@cool.haxx.se:/cvsroot/curl

and here is the failure message at the end of a long run: 

14:56:41 [I] Log message: mention curl_version_info
14:56:41 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -r 1.2 docs/libcurl/curl_version.3
14:56:43 [I] [Ok]
14:56:43 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
14:56:43 [W] [Status 1]
14:56:43 [C] Couldn't replay changeset
14:56:44 [C] Upstream change application failed
Traceback (most recent call last):
  File "/usr/local/bin/tailor", line 8, in <module>
    load_entry_point('tailor==0.9.31', 'console_scripts', 'tailor')()
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/tailor.py", line 342, in main   
    tailorizer()
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/tailor.py", line 147, in __call__
    self.update()
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/tailor.py", line 111, in update 
    applyable=self._applyable, applied=self._applied)
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/dualwd.py", line 97, in applyPendingChangesets
    applied=applied)
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/source.py", line 141, in applyPendingChangesets
    replay(c)
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/dualwd.py", line 108, in replayChangeset
    self.target.replayChangeset(changeset)
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/target.py", line 126, in replayChangeset
    entries, tags = changeset.tags)
  File "/usr/local/stow/python-release25-maint-2008-05-12/lib/python2.5/site-packages/tailor-0.9.31-py2.5.egg/vcpx/repository/darcs/target.py", line 77, in _commit
    "%s returned status %d" % (str(record), record.exit_status))
vcpx.source.ChangesetApplicationFailure: /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe returned status 1

real    132m32.031s
user    9m16.645s
sys     4m17.021s

Change History

comment:1 Changed 4 years ago by lele

  • Status changed from new to closed
  • Resolution set to worksforme

Same as comment:ticket:151:2.

comment:2 Changed 4 years ago by zooko

  • Status changed from closed to reopened
  • Resolution worksforme deleted

I upgraded tailor and then tried it again, and this time it got past the changeset mentioned above, but eventually (the next day, after many hours of work), stopped on this: 

11:15:17 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.91 acinclude.m4
11:15:20 [I] [Ok]
11:15:20 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
11:15:22 [I] [Ok]
11:15:22 [I] -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
11:15:22 [I] Changeset #7731
11:15:22 [I] Changeset "2006-07-01 17:07:12 by yangtse"
11:15:22 [I] Log message: Get some debug info
11:15:23 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.92 acinclude.m4
11:15:25 [I] [Ok]
11:15:25 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
11:15:26 [I] [Ok]
11:15:26 [I] -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
11:15:26 [I] Changeset #7732
11:15:26 [I] Changeset "2006-07-02 01:17:37 by yangtse"
11:15:26 [I] Log message: Fix shell globbing in CURL_CHECK_FUNC_GETNAMEINFO
11:15:26 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.34 ares/acinclude.m4
11:15:29 [I] [Ok]
11:15:29 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.93 acinclude.m4
11:15:31 [I] [Ok]
11:15:31 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
11:15:31 [W] [Status 1]
11:15:31 [C] Couldn't replay changeset
11:15:31 [C] Upstream change application failed
Traceback (most recent call last):
  File "/usr/local/bin/tailor", line 8, in <module>
    load_entry_point('tailor==0.9.32', 'console_scripts', 'tailor')()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 342, in main
    tailorizer()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 147, in __call__
    self.update()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 111, in update
    applyable=self._applyable, applied=self._applied)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/dualwd.py", line 97, in applyPendingChangesets
    applied=applied)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/source.py", line 141, in applyPendingChangesets
    replay(c)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/dualwd.py", line 108, in replayChangeset
    self.target.replayChangeset(changeset)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/target.py", line 126, in replayChangeset
    entries, tags = changeset.tags)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/repository/darcs/target.py", line 86, in _commit
    "%s returned status %d" % (str(record), record.exit_status))
vcpx.source.ChangesetApplicationFailure: /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe returned status 1

comment:3 Changed 4 years ago by zooko 

$ darcs whatsnew -s
M ./acinclude.m4 -30 +25
M ./ares/acinclude.m4 -1 +22
HACK wonwin-mcbrootles-computer:~/playground/libcurl/tailored$ darcs record --all --patch="whee" --author="whoever"
Finished recording patch 'whee'

So maybe this was an instance of  http://bugs.darcs.net/issue687 (simultaneous record/get => bad bad things (2.0.0 + 220)) -- perhaps because I was doing a darcs pull simultaneously it somehow caused darcs to fail with exit code 1?

Lelit: is there a record of the stdout/stderr from the call to darcs that failed with exit code 1?

comment:4 Changed 4 years ago by zooko

I restarted tailor and this time it succeeded at doing the same darcs record: 

2008-05-20 11:15:26     INFO: Changeset #7732
2008-05-20 11:15:26     INFO: Changeset "2006-07-02 01:17:37 by yangtse"
2008-05-20 11:15:26     INFO: Log message: Fix shell globbing in CURL_CHECK_FUNC_GETNAMEINFO
2008-05-20 11:15:26     INFO: /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.34 ares/acincl
ude.m4
2008-05-20 11:15:29     INFO: [Ok]
2008-05-20 11:15:29     INFO: /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.93 acinclude.m
4
2008-05-20 11:15:31     INFO: [Ok]
2008-05-20 11:15:31     INFO: /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
2008-05-20 11:15:31  WARNING: [Status 1]
2008-05-20 11:15:31 CRITICAL: Couldn't replay changeset
2008-05-20 11:15:31 CRITICAL: Upstream change application failed
2008-05-20 11:47:56     INFO: Updating "project" in "/Users/wonwinmcbrootles/playground/libcurl/tailored"
2008-05-20 11:47:56     INFO: $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl rlog -d "2006-07-01 17:07:12 UTC<" -b curl 2>&1
2008-05-20 11:48:57     INFO: [Ok]
2008-05-20 11:49:03     INFO: Cached information about 2481 pending changesets
2008-05-20 11:49:03     INFO: Applying pending upstream changesets
2008-05-20 11:49:03     INFO: Changeset #1
2008-05-20 11:49:03     INFO: Changeset "2006-07-02 01:17:37 by yangtse"
2008-05-20 11:49:03     INFO: Log message: Fix shell globbing in CURL_CHECK_FUNC_GETNAMEINFO
2008-05-20 11:49:03     INFO: /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
2008-05-20 11:49:03     INFO: [Ok]
2008-05-20 11:49:03     INFO: -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
2008-05-20 11:49:03     INFO: Changeset #2
2008-05-20 11:49:03     INFO: Changeset "2006-07-02 01:21:54 by yangtse"

Lelit: is there a way to configure tailor to capture stderr and stdout from darcs and, if there is a failure, then log that information for post mortem analysis?

comment:5 Changed 4 years ago by zooko

No, this can't be an instance of  http://bugs.darcs.net/issue687 because it just happened again even though I've stopped messing with the tailored directory while tailor is working. It stopped like this: 

15:23:54 [I] Changeset #923
15:23:54 [I] Changeset "2007-03-31 21:01:18 by bagder"
15:23:54 [I] Log message: Better deal with NULL pointers.
CID 3 and 4 from the coverity.com scan.
15:23:54 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl -q update -d -P -r 1.99 lib/formdata.c
15:23:57 [I] [Ok]
15:23:57 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
15:23:57 [W] [Status 1]
15:23:57 [C] Couldn't replay changeset
15:23:57 [C] Upstream change application failed
Traceback (most recent call last):
  File "/usr/local/bin/tailor", line 8, in <module>
    load_entry_point('tailor==0.9.32', 'console_scripts', 'tailor')()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 342, in main
    tailorizer()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 147, in __call__
    self.update()
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/tailor.py", line 111, in update
    applyable=self._applyable, applied=self._applied)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/dualwd.py", line 97, in applyPendingChangesets
    applied=applied)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/source.py", line 141, in applyPendingChangesets
    replay(c)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/dualwd.py", line 108, in replayChangeset
    self.target.replayChangeset(changeset)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/target.py", line 126, in replayChangeset
    entries, tags = changeset.tags)
  File "/usr/local/stow/python-release25-maint-2008-05-15/lib/python2.5/site-packages/tailor-0.9.32-py2.5.egg/vcpx/repository/darcs/target.py", line 86, in _commit
    "%s returned status %d" % (str(record), record.exit_status))
vcpx.source.ChangesetApplicationFailure: /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe returned status 1

real 166m45.849s
user 12m33.818s
sys  7m16.449s

$ darcs whatsnew -s
M ./lib/formdata.c -9 +15
$ darcs record --all -m 'test' -A 'aythor'
Finished recording patch 'test'
$ echo $?
0

And then resuming tailor resumed successfully: 

$ time tailor --configfile=./tailor.config 
15:28:50 [I] Updating "project" in "/Users/wonwinmcbrootles/playground/libcurl/tailored"
15:28:50 [I] $ cvs -f -d :pserver:anonymous@cool.haxx.se:/cvsroot/curl rlog -d "2007-03-31 20:47:23 UTC<" -b curl 2>&1
15:29:26 [I] [Ok]
15:29:30 [I] Cached information about 1492 pending changesets
15:29:30 [I] Applying pending upstream changesets
15:29:30 [I] Changeset #1
15:29:30 [I] Changeset "2007-03-31 21:01:18 by bagder"
15:29:30 [I] Log message: Better deal with NULL pointers.
CID 3 and 4 from the coverity.com scan.
15:29:30 [I] /Users/wonwinmcbrootles/playground/libcurl/tailored $ darcs record --all --pipe
15:29:31 [I] [Ok]
15:29:31 [I] -*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*

So I really need to edit tailor to capture the darcs stdout/stderr in a case like this!

comment:6 Changed 4 years ago by lele

Using debug = True will cause tailor to copy stdout/stderr of the execution in its log. Please, retry with latest tailor.

comment:7 Changed 4 years ago by lele

  • Status changed from reopened to closed
  • Resolution set to worksforme

I consider this closed. Current tailor prints the stdout of the failing darcs record, even without debug=True. Feel free to reopen with other details.

Note: See TracTickets for help on using tickets.