Changeset 219 in tracdarcs


Ignore:
Timestamp:
12/10/10 10:26:21 (2 years ago)
Author:
lele@…
Hash name:
20101210092621-7a6fb-476dbfbdb9e72fca0968bbd1c11433fd6d68e7df
Message:

Possible fix for #24
When the argument isn't recognized as a valid revision number, raise
NoSuchChangeset? instead of TracError?, as the svn backend does.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • tracdarcs/repository.py

    r216 r219  
    155155        else: 
    156156            youngest = self.get_youngest_rev() 
    157             if rev is None or rev == "": 
     157            if rev is None or (isinstance(rev, basestring) and 
     158                               rev.lower() in ('', 'head', 'latest', 'youngest')): 
    158159                return youngest 
    159160            try: 
    160161                rev = int(rev) 
    161             except ValueError, le: 
    162                 raise TracError('Ill-formed revision: %s, error: %s' % (rev, le)) 
     162            except (ValueError, TypeError): 
     163                raise NoSuchChangeset(rev) 
    163164            if rev > youngest: 
    164                 rev = youngest 
     165                raise NoSuchChangeset(rev) 
    165166        return rev 
    166167 
Note: See TracChangeset for help on using the changeset viewer.