Changeset 70 in tracdarcs for tracdarcs/repository.py

Timestamp:

12/08/07 12:08:10 (5 years ago)

Author:

lele@…

Hash name:

20071208110810-7a6fb-608bfccc78b5fffe31be99be386319608a7fa0a5

Message:

Remove the ugly hack, properly catch the exception
Sometime the sqlite runtime raise a strange exception on commit here, most
probably related to a concurrent update of the database. Since we are
trying to store the cache for the textual representation, absorb the error
and keep going: reasonably that same value has been stored shortly before...

File:

• tracdarcs/repository.py (modified) (1 diff)

tracdarcs/repository.py

@@ -293 +293 @@
         # save the file content in the cache
 
-        # UGLY HACK: the following line is required otherwise
-        # db.commit() (pysqlite-2.3.2,winxp) throws
-        # OperationalError: 'SQL logic error or missing database'
-        #self.__db.cnx.cnx.isolation_level = None
-        # END UGLY HACK
-
         c = self.__db.cursor()
         c.execute( 'INSERT INTO darcs_cache(node_id,rev,content) '
                 'VALUES (%s,%s,%s)',
                 (self.__node_id,self.rev,buffer(data)) )
-        self.__db.commit()
+        try:
+            self.__db.commit()
+        except Exception, e:
+            # Sometimes db.commit() (sqllite) throws an
+            # OperationalError: 'SQL logic error or missing database'
+            # Since this is just a cache, we simply notify and keep
+            # going.
+            self.__log.warning("Error writing cache: %s", e)
         return StringIO.StringIO( data )